KhronosGroup / SPIRV-Tools

Apache License 2.0
1.09k stars 559 forks source link

MSVC2015 Bazel builds are consistently failing #5022

Closed dneto0 closed 1 year ago

dneto0 commented 1 year ago

Example from the log:

[779 / 793] Compiling test/opt/loop_optimizations/fusion_legal.cpp; 7s local ... (8 actions running) [936 / 951] Compiling test/opt/ccp_test.cpp; 7s local ... (8 actions running) ERROR: T:/src/github/spirv-tools/BUILD.bazel:465:11: Linking base_text_to_binary.extension_test.exe failed: (Exit 1201): link.exe failed: error executing command C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\bin\amd64\link.exe @bazel-out/x64_windows-fastbuild/bin/base_text_to_binary.extension_test.exe-2.params LINK : fatal error LNK1201: error writing to program database 'C:\cygwin64\home\kbuilder_bazel_kbuilder\garyuiiy\execroot__main__\bazel-out\x64_windows-fastbuild\bin\base_text_to_binary.extension_test.pdb'; check for insufficient disk space, invalid path, or insufficient privilege INFO: Elapsed time: 288.404s, Critical Path: 28.14s INFO: 991 processes: 440 internal, 551 local. FAILED: Build did NOT complete successfully FAILED: Build did NOT complete successfully

dneto0 commented 1 year ago

It's the only bazel build. We should test bazel with a newer compiler.

MSVC 2015 has had a replacement for more than 5 years, so we can drop support for it.

dneto0 commented 1 year ago

@Keenuts you said the VM was running out of disk space. But I think it's still worth dropping MSVC2015 support.