search

KhronosGroup / SPIRV-Tools

Apache License 2.0
1.05k stars 548 forks source link

spriv-tools build of spirv-cross is really old #5526

Open alecazam opened 8 months ago

alecazam commented 8 months ago

We ended up pulling copies of this from the VulkanSDK. But including a 2021 version of this alongside newer glslc/spirv-opt isn't ideal. I only found this out since I did a -version on all the tools.

alecazam commented 8 months ago

Sorry this was the Win build(so spirv-cross.exe). I'm not sure about macOS build.

s-perron commented 7 months ago

@jeremyg-lunarg This seems to be an issue with the SDK.

I'm not too sure what is referred to. When I tried the tools on Linux, the SDK v1.3.261.1 has 

~/VulkanSDK/1.3.261.1 » `find . -name spirv-opt` --version                                                                                                                                                                                             stevenperron@stevenperron-cloudtop
SPIRV-Tools v2023.4 v2022.4-296-ge553b884

and

~/VulkanSDK/1.3.261.1 » `find . -name spirv-cross` --help 2>&1 | head -2                                                                                                                                                                               stevenperron@stevenperron-cloudtop
Git commit: bccaa94d Timestamp: 2023-08-29T20:41:51
Usage: spirv-cross <...>

I don't see anything from 2021. @alecazam Is it possible you have a different spirv-opt or spirv-cross on your path?

jeremy-lunarg commented 7 months ago

Reiterating on what @s-perron said, the spirv-cross from the latest vulkan sdk has the timestamp 2023-10-17T17:31:47. @alecazam, which "build of spirv-cross" is old? I don't an issue with what's provided in the latest SDK.