KhronosGroup / SPIRV-Tools

Apache License 2.0
1.09k stars 559 forks source link

spirv-val: Add missing NonSemantic.Shader.DebugInfo.100 #5846

Open spencer-lunarg opened 1 month ago

spencer-lunarg commented 1 month ago

Adds missing coverage for NonSemantic.Shader.DebugInfo.100 where it was different from OpenCL.DebugInfo.100

(Created 2 commits prior to reduce the copy-and-pasting in the tests)

spencer-lunarg commented 1 month ago

@alan-baker I see it is failing CI in https://btx.cloud.google.com/invocations/36895f7b-5b6d-4dac-8efe-c9225e6f04d6/targets/graphics_shader_compiler%2Fspirv-tools%2Fshaderc-smoketest%2Fpresubmit/log but these errors make no sense, locally it runs fine and all the errors are around not being able to run spirv-as on thing, not sure if you have seen this before

alan-baker commented 1 month ago

Can you rebase on main? SPIRV-Headers merged a PR to remove aliases as separate grammar entries. The tooling is up-to-date on main.