search

KhronosGroup / SPIRV-Tools

Apache License 2.0
1.09k stars 559 forks source link

ci: Make MacOS builds only run if other things pass #5872

Closed spencer-lunarg closed 1 week ago

spencer-lunarg commented 2 weeks ago

Recently we have found productivty slow down in other KhronosGroups repos because it can take hours for CI to run due to running out of Github Actions minutes. We have found that MacOS/iOS are charged as 10x the minute cost which really starts to add up. The goal is to not have those expensive CI actions run unless we know other things work first.

(There is an internal issue on this, but for short term, I have just been apply these types of YAML chanegs aroudn the repos https://gitlab.khronos.org/khronos-general/khronos-issues/-/issues/127)

s-perron commented 1 week ago

I'm in favour of this change, but is it implemented correctly? It seems like the macos build did not run even when the others passed. Is that expected?

s-perron commented 1 week ago

I see what is going on. The job has a different name now, and the branch protection rules are requiring one with the old name. I'll work around that.