search

KhronosGroup / SYCL-Docs

SYCL Open Source Specification
Other
116 stars 68 forks source link

Remove info::platform::profile from the header #608

Closed VerenaBeckham closed 1 month ago

VerenaBeckham commented 2 months ago

It is never described in the spec. Alternatively, we could bring the description in the spec back and mark it deprecated.

gmlueck commented 2 months ago

FWIW, DPC++ does seem to implement this, but I'm still in favor of removing it from the spec.

I think this is a holdover from OpenCL, which supports the CL_PLATFORM_PROFILE query.

TApplencourt commented 2 months ago

CI failure is due to new the "PR to CTS" thingy step

VerenaBeckham commented 2 months ago

@psalz could you please have a look at the CI failure?

psalz commented 2 months ago

@psalz could you please have a look at the CI failure?

~Hmm, might've been spurious. Re-running the job fixed it 🤷‍♂️~

Edit: Nevermind, I believe it's because you're not a member of the @KhronosGroup organization, the job failed to assign the issue to you. I will look into that!

tomdeakin commented 2 months ago

Waiting on CTS fix.

VerenaBeckham commented 1 month ago

The CTS fix has been implemented and merged. This can now also be merged.

tomdeakin commented 1 month ago

Wg approved to merge.