KhronosGroup / VK-GL-CTS

Khronos Vulkan, OpenGL, and OpenGL ES Conformance Tests
https://www.khronos.org/
Apache License 2.0
526 stars 294 forks source link

Implement support for the EGL_EXT_config_select_group extension #393

Closed okias closed 8 months ago

okias commented 1 year ago

Ref: https://registry.khronos.org/EGL/extensions/EXT/EGL_EXT_config_select_group.txt

Closes: https://github.com/KhronosGroup/VK-GL-CTS/issues/392

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.

okias commented 1 year ago

I'll need a bit assistance with updating the EGL headers. Running python3 scripts/egl/gtf_wrapper.py gives me:

ModuleNotFoundError: No module named 'egl'
enunes commented 1 year ago

I'll need a bit assistance with updating the EGL headers. Running python3 scripts/egl/gtf_wrapper.py

From what I saw you can update scripts/egl/common.py with the new commit of the EGL Registry repository and sha256 of the file, then run python3 scripts/gen_egl.py. Looks like you may also need to add the extension name to EXTENSIONS in scripts/egl/common.py otherwise the new enum for the extension doesn't actually get generated in the headers.

okias commented 1 year ago

Thank you @enunes , worked with a charm!

okias commented 1 year ago

What do you think, @nwnk ?

AlexGalazin-IMG commented 1 year ago

Collabora is a Khronos member. Please resubmit through the internal gerrit

okias commented 1 year ago

Thanks, it's there: https://gerrit.khronos.org/c/vk-gl-cts/+/12316

okias commented 8 months ago

@AlexGalazin-IMG Hello, could I ask for review of the Gerrit https://gerrit.khronos.org/c/vk-gl-cts/+/12316 PR? Thank you