search

KhronosGroup / VK-GL-CTS

Khronos Vulkan, OpenGL, and OpenGL ES Conformance Tests
https://www.khronos.org/
Apache License 2.0
521 stars 290 forks source link

Fix egl_fence_persistent_buffer deinit on GLES 2.0 #435

Open enunes opened 8 months ago

enunes commented 8 months ago

On GLES 2.0 only drivers, the egl_fence_persistent_buffer test fails to create its GLES 3.1 context and an exception is thrown at chooseSingleConfig, which aborts its init early. The initialization doesn't reach initGLFunctions and GL function pointers are left uninitialized, which causes a segfault and crash in the deinit path. Fix the deinit path so that it doesn't crash but just reports "No matching EGL config found" like other EGL tests with those drivers.

Affects: dEQP-EGL.functional.fence_sync.valid.egl_fence_persistent_buffer

This has been crashing on two GLES 2.0 drivers on mesa since this CTS update https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/24947 .

lordalcol commented 6 months ago

This is now being tested and reviewed in Khronos CI.

okias commented 1 month ago

How's the testing going?