Bug Report: function createHitShaderBindingTable() passed the wrong SBT size

KhronosGroup / VK-GL-CTS

Khronos Vulkan, OpenGL, and OpenGL ES Conformance Tests

https://www.khronos.org/

Apache License 2.0

521 stars 290 forks source link

Bug Report: function createHitShaderBindingTable() passed the wrong SBT size #439

Open LinKArftc opened 7 months ago

LinKArftc commented 7 months ago

https://github.com/KhronosGroup/VK-GL-CTS/blob/d71a36db16d98313c431829432a136dbda692a08/external/vulkancts/modules/vulkan/ray_tracing/vktRayTracingPipelineFlagsTests.cpp#L509C52-L509C52

m_testInstance.shaderGroupHandleSize is just the size of a single shaderGroupHandle, the size of the entire SBT(sbt.getAlignment() * hitGroupCount) should be passed here.

Case like "dEQP-VK.ray_tracing_pipeline.pipeline_no_null_shaders_flag.gpu.boxes.stride_3.offset_7.no_libs.any" would hit this bug.

rg3igalia commented 2 months ago

This was fixed in 3dcd4b1f53bfeed5dc1907ace103a86cafc0667a