Add tests for EXT_texture_format_BGRA8888

[kusma]

This adds tests for EXT_texture_format_BGRA8888, including the recent changes (see https://github.com/KhronosGroup/OpenGL-Registry/pull/603)

[zmike]

This should be submitted through gerrit since it will have to be copied there for processing anyway.

[kusma]

I am too stupid to use Gerrit. Could someone who has spent the years it takes to learn how to do even the most basic stuff in it please submit it there on my behalf?

[zmike]

• git remote add khronos ssh://kusma@gerrit.khronos.org:29418/vk-gl-cts
• git push khronos HEAD:refs/for/opengl-cts-4.6.3
• open CL link
• click Mark Active at the top
• you now possess multiple years of gerrit knowledge

[kusma]

$ git push khronos HEAD:refs/for/opengl-cts-4.6.3
Enumerating objects: 52, done.
Counting objects: 100% (52/52), done.
Delta compression using up to 32 threads
Compressing objects: 100% (36/36), done.
Writing objects: 100% (36/36), 3.37 KiB | 3.37 MiB/s, done.
Total 36 (delta 32), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (32/32)
remote: Processing changes: refs: 1, done    
remote: ERROR: commit 428d85f: missing Change-Id in message footer
remote: 
remote: Hint: to automatically insert a Change-Id, install the hook:
remote:   gitdir=$(git rev-parse --git-dir); scp -p -P 29418 kusma@gerrit.khronos.org:hooks/commit-msg ${gitdir}/hooks/
remote: (for OpenSSH >= 9.0 you need to add the flag '-O' to the scp command)
remote: or, for http(s):
remote:   f="$(git rev-parse --git-dir)/hooks/commit-msg"; curl -o "$f" https://gerrit.khronos.org/tools/hooks/commit-msg ; chmod +x "$f"
remote: and then amend the commit:
remote:   git commit --amend --no-edit
remote: Finally, push your changes again
remote: 
To ssh://gerrit.khronos.org:29418/vk-gl-cts
 ! [remote rejected]     HEAD -> refs/for/opengl-cts-4.6.3 (commit 428d85f: missing Change-Id in message footer)
error: failed to push some refs to 'ssh://gerrit.khronos.org:29418/vk-gl-cts'

...Trying to follow the advice from the remote:

$ gitdir=$(git rev-parse --git-dir); scp -p -P 29418 kusma@gerrit.khronos.org:hooks/commit-msg ${gitdir}/hooks/
subsystem request failed on channel 0
scp: Connection closed

So, still too complicated for me, it seems.

[kusma]

Seems it was that missing -O-argument. Why on earth doesn't this default to saying what you do on an up-to-date system, and rather tell what to fix if your system is out-of-date instead?

But that's just every little detail with Gerrit. Just a plain human-unfriendly tool.

[kusma]

...and now I get a ton of errors like this:

remote: ERROR: Implicit Merge of 8a096e1 Tests for VK_EXT_pipeline_library_group_handles
remote: ERROR: Implicit Merge of 0e8d426 Framework changes for VK_KHR_shader_quad_scope
remote: ERROR: Implicit Merge of cdd59af Tests for VK_EXT_image_sliced_view_of_3d

I guess it's based on the wrong branch compared to the refs/for/opengl-cts-4.6.3-ref, but uh. Which to I change? opengl-cts-4.6.3 seems pretty old...

[kusma]

click Mark Active at the top

... manually for every commit in the series, it seems. Great UI!

you now possess multiple years of gerrit knowledge

You're saying this as if it's my first time submitting something to Gerrit. It's just obscure and human unfriendly on every step, and I have forgotten all the details by tomorrow.

And just for the record, every step (apart from adding the remote) failed in some way that took a while for me to figure out. Some steps failed in multiple ways.

[zmike]

I guess I should've pointed you to https://gitlab.khronos.org/Tracker/vk-gl-cts/-/wikis/gerrit-workflow instead of trying to describe my workflow. Sounds like you're missing the commit log hook and also I forgot to mention that you don't submit patches off "main", you submit them from the branch you're submitting them to. 4.6.3 is, relatively speaking, not that old.

[kusma]

Sorry for being a bit passive-aggressive there. As you might understand, I find Gerrit extremely frustrating, but thanks a lot for helping.

I decided to send the MR to the main branch, simply because nothing seemingly had been sent to any of the opengl branches in a long time, but there were lots of changes submitted for main. Let me know if I need to change that.

And for completeness, here's the change on Gerrit: https://gerrit.khronos.org/c/vk-gl-cts/+/13915/1

[AlexGalazin-IMG]

There is this page https://gitlab.khronos.org/Tracker/vk-gl-cts/-/wikis/branches#main-branch which describes where to submit changes.

[kusma]

Closing the PR, because this has been submitted to Gerrit