search

KhronosGroup / VK-GL-CTS

Khronos Vulkan, OpenGL, and OpenGL ES Conformance Tests
https://www.khronos.org/
Apache License 2.0
525 stars 293 forks source link

Fix: Test PVRTC extension and always use power-of-two dimensions for PVRTC1 #451

Open spnda opened 8 months ago

spnda commented 8 months ago

The CTS tests always use random image sizes for testing images, which was not valid for PVRTC1 textures. With 1.3.279 a VUID was added to require power-of-two dimensions for PVRTC1 textures, as discussed in https://github.com/KhronosGroup/Vulkan-Docs/issues/1991.

Also, this fixes a bug introduced with https://github.com/KhronosGroup/VK-GL-CTS/commit/4c7e4e98f9e577ecd5bf2d922cd756aadc02701a, as it required the extension to be present for the PVRTC formats to be tested, but it was never added as a extension to be enabled, so PVRTC textures were never tested.

CLAassistant commented 8 months ago

CLA assistant check
All committers have signed the CLA.

lordalcol commented 7 months ago

Thank you for your submission, we are reviewing it.