search

KhronosGroup / Vulkan-Docs

The Vulkan API Specification and related tools
Other
2.7k stars 452 forks source link

`VK_SHADER_STAGE_SUBPASS_SHADING_BIT_HUAWEI` is missing documentation, maybe also rename? #2343

Open Rua opened 3 months ago

Rua commented 3 months ago

In the documentation of VkShaderStageFlagBits, a definition for VK_SHADER_STAGE_SUBPASS_SHADING_BIT_HUAWEI is missing. This would have been easy enough for me to fix directly in a PR, but I noticed that in VkPipelineStageFlagBits2, the older VK_PIPELINE_STAGE_2_SUBPASS_SHADING_BIT_HUAWEI is now replaced with VK_PIPELINE_STAGE_2_SUBPASS_SHADER_BIT_HUAWEI. Does this mean that for the shader stage, the name VK_SHADER_STAGE_SUBPASS_BIT_HUAWEI should also be introduced as a replacement?

PanGao-h commented 3 months ago

VK_PIPELINE_STAGE_2_SUBPASS_SHADING_BIT_HUAWEI is not following the rules of expressing pipeline shader stage bits well and had been updated here. VK_SHADER_STAGE_SUBPASS_SHADING_BIT_HUAWEI has similar issue, but the name SUBPASS may be a bit too general. If no strong opinion in Khronos internal discussion, we intend to keep it unchanged. Please stay tuned for further update.