search

KhronosGroup / Vulkan-Guide

One stop shop for getting started with the Vulkan API
Creative Commons Attribution 4.0 International
1.96k stars 169 forks source link

Rename default branch to 'main' #205

Closed oddhack closed 1 year ago

oddhack commented 1 year ago

This repo slipped under the radar somehow but should do this to abide by Khronos policy. Not sure who admins the repo but I'm happy to do it if you want - as with all the other repos, it's just a matter of invoking the github renaming tool.

spencer-lunarg commented 1 year ago

Not sure who admins the repo but I'm happy to do it if you want

I have no experience doing it, so if you want to do it that would probably be better

oddhack commented 1 year ago

Not sure who admins the repo but I'm happy to do it if you want

I have no experience doing it, so if you want to do it that would probably be better

Go to Settings / Code & Automation / Branches and edit the default branch, is all.

Happy to do it but we should have a heads-up - I will mention it on the Maintenance call tomorrow. There is minimal impact as Github sets up some forwarding as part of the renaming tool, but best for people with local repo clones to pull the new main branch and switch to using that.

marty-johnson59 commented 1 year ago

@gpx1000 and I typically review Guide issues on the Vulkan samples call (next on on Monday). This looks straight forward enough, but let's review there for visibility.

oddhack commented 1 year ago

@gpx1000 and I typically review Guide issues on the Vulkan samples call (next on on Monday). This looks straight forward enough, but let's review there for visibility.

@marty-johnson59 Did you get a chance to review this yet?

marty-johnson59 commented 1 year ago

Not yet - Steve was OOO on our last call. @gpx1000, can you take a look and if OK, I'll merge. Thx

gpx1000 commented 1 year ago

It LGTM. Go ahead and merge please Marty. Sorry I've been so reclusive, am getting closer to back to normal.

marty-johnson59 commented 1 year ago

Great to hear!

OK, I edited the default branch to "main" - hoping that doesn't break anything. LMK if there's more to be done here. Thx!

oddhack commented 1 year ago

Great to hear!

OK, I edited the default branch to "main" - hoping that doesn't break anything. LMK if there's more to be done here. Thx!

Thanks, LGTM. You may also want to edit the branch protection settings (same settings page as the default branch) to protect 'main' so only repo admins can push commits to it, otherwise nothing more TBD. Feel free to close whenever you like.

marty-johnson59 commented 1 year ago

Done. BTW, I suppose we should make the same change (to "main") on the Samples repo? That's still set to "master"

oddhack commented 1 year ago

Done. BTW, I suppose we should make the same change (to "main") on the Samples repo? That's still set to "master"

Yes, that would be great. Thanks!

marty-johnson59 commented 1 year ago

Done, closing