search

KhronosGroup / Vulkan-Headers

Vulkan header files and API registry
https://www.vulkan.org/
Other
831 stars 212 forks source link

Vulkan-Hpp now includes `.cppm` C++20 module; inclusion in Vulkan-Headers #410

Closed sharadhr closed 1 year ago

sharadhr commented 1 year ago

As of earlier today, effort to develop a C++20 module interface file has been completed and merged into Vulkan-Hpp, called vulkan.cppm.

Is there a chance this file could be added to Vulkan-Headers and thence downstream, too?

Thanks!

juan-lunarg commented 1 year ago

Is there a chance this file could be added to Vulkan-Headers and thence downstream, too?

@oddhack handles updating the files from Vulkan-Hpp so I will defer to them. I don't see an issue with mirroring this file.

If we do mirror the file we should update the docs in this repo to state that we mirror the file explicitly. Currently our documentation lists that we only mirror *.hpp files from Vulkan-Hpp:

Vulkan C++ Binding Repository (https://github.com/KhronosGroup/Vulkan-Hpp)

As of the Vulkan-Docs 1.2.182 spec update, the Vulkan-Hpp headers have been split into multiple files. All of those files are now included in this repository.

    include/vulkan/*.hpp
sharadhr commented 1 year ago

Sounds good. Should I start a PR for this?

juan-lunarg commented 1 year ago

Sounds good. Should I start a PR for this?

I believe there is a process for getting files mirrored in from the Vulkan-Docs and Vulkan-Hpp.

I'll have to defer to @oddhack since it would impact their workflow.

oddhack commented 1 year ago

The .cppm file is published in Vulkan-Headers as part of the spec update process now. I tweaked CONTRIBUTING.md to note the new file but suggest @sharadhr review the README etc. to see if anything else needs to be added; if not this can be closed.

sharadhr commented 1 year ago

Looks good to me; no changes needed. Thanks for the quick updates!