search

KhronosGroup / Vulkan-Headers

Vulkan header files and API registry
https://www.vulkan.org/
Other
846 stars 220 forks source link

Set -DVULKAN_HEADERS_ENABLE_MODULE=ON when MSVC 17.11 rolls out to github actions #486

Closed charles-lunarg closed 4 months ago

charles-lunarg commented 5 months ago

The Vulkan-Hpp module works for the most part, save for an internal compiler error in MSVC which required working around.

ICE details: https://developercommunity.visualstudio.com/t/On-building-a-C20-module:-fatal--error/10469799

This issue is a reminder to disable the workaround when the fix rolls out.

charles-lunarg commented 4 months ago

On further consideration, multiple users have been impacted by the addition of the module support due to using an MSVC version that is buggy.

It would be better for future SDK and general use to simply not allow modules in a known-bad MSVC version.