search

KhronosGroup / Vulkan-Headers

Vulkan header files and API registry
https://www.vulkan.org/
Other
846 stars 220 forks source link

Makefile to import generated scripts and headers when doing a spec update #487

Closed oddhack closed 5 months ago

oddhack commented 5 months ago

Motivated by recent problems building the SC 1.0.15 spec update - will import to VulkanSC-Headers and tweak once it's proven out for Vulkan-Headers.

The Makefile may need to be modified when directory structure is changed or new scripts or headers are added.

oddhack commented 5 months ago

make is the right tool for the task and python is not.

It doesn't have to be named 'Makefile' if that will assuage the concern.

oddhack commented 5 months ago

N.b. if 'building the project' isn't necessary, the same consideration would apply to the cmake stuff IMO. The BUILD.md file literally starts with 'Instructions for building this repository'.

charles-lunarg commented 5 months ago

Ah, the filename was probably my biggest concern. So changing that would assuage all of my concern.

charles-lunarg commented 5 months ago

My "building isn't necessary" is referencing how this is a header only project. Although now it is mostly header only, with vulkan.cppm blurring the lines. A user could clone/download the Vulkan-Headers repo, point their compiler to the include folder and pretty much be done. So while CMake is indeed used to 'build' the project, it isn't building binaries, rather it is setting up a CMake target for downstream users as well as managing the install step for package managers.