search

KhronosGroup / Vulkan-Headers

Vulkan header files and API registry
https://www.vulkan.org/
Other
846 stars 220 forks source link

Undefine major and minor through <sys/sysmacros.h> #511

Closed gulfemsavrun closed 1 month ago

gulfemsavrun commented 1 month ago

<sys/sysmacros.h> is included through some other headers. This results in major(x) being resolved to gnu_dev_major(x) which is an expression in a constructor initializer list. This patch includes <sys/sysmacros.h> at the very beginning, and undefines major and minor to avoid them to be resolved to gnu_dev_major(x) or gnu_dev_minor(x).

CLAassistant commented 1 month ago

CLA assistant check
All committers have signed the CLA.

charles-lunarg commented 1 month ago

Unfortunately, I cannot accept the PR because this repo only contains copies of the header files, it is not the source for them as documented in CONTRIBUTING.md.

The Vulkan-Hpp header (and now module) files are in https://github.com/KhronosGroup/Vulkan-Hpp. Any changes to those files must go to that repository.

oddhack commented 1 month ago

@charles-lunarg you can also move issues to other KhronosGroup repos (or ask me to, if you don't have the right permissions).

(Edit: no, NM - this is a PR not an issue and those can't be moved. My bad.)