search

KhronosGroup / Vulkan-Hpp

Open-Source Vulkan C++ API
Apache License 2.0
3.08k stars 304 forks source link

Don't export symbols in `vk::detail` namespace #1931

Closed sharadhr closed 1 month ago

sharadhr commented 1 month ago

Resolves #1928.

asuessenbach commented 1 month ago

@sharadhr This PR just removed the symbols from the vk::detail namespace. Would it be possible to export them in the vk::detail namespace, instead?

sharadhr commented 1 month ago

I'm sure that's possible, but do we really want to expose the detail stuff? I was under the impression the point of detail was to tell users that those symbols are not meant to be part of the public user-facing API, and not exporting them in the C++ module makes this very explicit.

asuessenbach commented 1 month ago

You're kind of right, that stuff is part of the detail namespace and thus not part of the "official" vulkan. But it seems, at least some guys want to use at least some of those functions. And as they are in the detail-namespace they (should) know, that they could be changed without further notice. That is, you can use them now (on your own risk) when you don't use modules, but you can't use them with modules. Which might be worth to be changed.