Loader settings bug fixes and expanded test coverage

charles-lunarg commented 2 weeks ago

Fix VK_INSTANCE_LAYERS bug when using vk_loader_settings.json - stack allocated variable would be indexed past the end of the array if more than 1 layer was present in the settings file, causing garbage to be read as a string.
Make vkEnumerateInstanceExtensionProperties return VK_INCOMPLETE correctly - When some layers are turned "off" in the settings file, the count of layers would be correct but VK_INCOMPLETE would be returned by mistake.
Intercept loader_log in Test Framework - allows seeing the output of VK_LOADER_DEBUG & the loader settings file log settings output directly, rather than going through the Debug Utils Messenger.
Re-enable readdir interception on MacOS which was disabled so address sanitizer could work, which no longer seems to be needed.

ci-tester-lunarg commented 2 weeks ago

CI Vulkan-Loader build queued with queue ID 301850.

charles-lunarg commented 2 weeks ago

Mingw is a known CI job failure - fixing that is lower priority than getting these changes in.

ci-tester-lunarg commented 2 weeks ago

CI Vulkan-Loader build # 2777 running.

ci-tester-lunarg commented 2 weeks ago

CI Vulkan-Loader build # 2777 passed.

christophe-lunarg commented 2 weeks ago

I am still getting RenderDoc to run automatically depiste not being enabled (loader log.txt): vk_loader_settings.json

ci-tester-lunarg commented 2 weeks ago

CI Vulkan-Loader build queued with queue ID 302495.

ci-tester-lunarg commented 2 weeks ago

CI Vulkan-Loader build # 2778 running.

ci-tester-lunarg commented 2 weeks ago

CI Vulkan-Loader build # 2778 passed.

ci-tester-lunarg commented 2 weeks ago

CI Vulkan-Loader build queued with queue ID 302774.

ci-tester-lunarg commented 2 weeks ago

CI Vulkan-Loader build # 2779 running.

ci-tester-lunarg commented 2 weeks ago

CI Vulkan-Loader build # 2779 failed.

ci-tester-lunarg commented 1 week ago

CI Vulkan-Loader build queued with queue ID 302973.

ci-tester-lunarg commented 1 week ago

CI Vulkan-Loader build # 2780 running.

ci-tester-lunarg commented 1 week ago

CI Vulkan-Loader build # 2780 passed.

ci-tester-lunarg commented 1 week ago

CI Vulkan-Loader build queued with queue ID 303023.

ci-tester-lunarg commented 1 week ago

CI Vulkan-Loader build # 2781 running.

ci-tester-lunarg commented 1 week ago

CI Vulkan-Loader build # 2781 passed.

charles-lunarg commented 1 week ago

Merging because all CI jobs passed (save for the known mingw failure case)

KhronosGroup / Vulkan-Loader