KhronosGroup / Vulkan-LoaderAndValidationLayers

**Deprecated repository** for Vulkan loader and validation layers
Apache License 2.0
414 stars 172 forks source link

Housekeeping: split up layer_validation_tests.cpp #1754

Open chrisforbes opened 7 years ago

jeremy-lunarg commented 7 years ago

Any thoughts/opinions on the dissection?

chrisforbes commented 7 years ago

I was going to start with:

krOoze commented 6 years ago

Since VUs are per-command, I propose splitting to one file per tested command (or rationaly multiple related ones). Structures that can be used independently by multiple commands can be a separate header.

Aditionally this could lead to ~two tests per file (small number of positive and negative tests). Each test setup takes over half second. Aggregating some tests shouldn't break things for the case the subtests succeed, and it could greatly improve testing time.

I think e.g. vkCmdSet* commands could be tested together, and so in single file.

And of course utils and whatever should be in separate file(s).

Thoughts?