search

KhronosGroup / Vulkan-LoaderAndValidationLayers

**Deprecated repository** for Vulkan loader and validation layers
Apache License 2.0
414 stars 172 forks source link

loader: Send device dispatch table address to ICDs #2579

Closed jdrouan-goog closed 6 years ago

jdrouan-goog commented 6 years ago

Send ICDs the device dispatch table address using VK_STRUCTURE_TYPE_LOADER_DEVICE_CREATE_INFO. This is to support implementations that need the handle to be in scope during the execution of CreateDevice.

See issue #2578

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

ianelliottus commented 6 years ago

Two generic points while I try to learn more about the goals for this change:

@lenny-lunarg 's first point reminds me that such a change will need to be formally changing the documented loader-ICD interface. It will probably need broader review and buy-in from others (including the desktop IHVs and potentially the Android loader and IHV folks).

@lenny-lunarg's 2nd point is a good one ... the desktop loader is shared by all of the ICDs on a system. Laptops often have an integrated and discrete ICD, which come from 2 different IHVs. If one driver is updated, the non-updated driver still needs to work with the loader that came along with the updated driver.

jfroy commented 6 years ago

See some more details in the related issue.

mark-lunarg commented 6 years ago

@jdrouan-goog, @ianelliottus, @lenny-lunarg, @jfroy, this repository will close for write access on Sunday, 5/13/2018. If it is pushed before that time it will be present in the follow-on Vulkan-Loader repository on Monday, otherwise a new PR will be required in the new repo.