Closed asuessenbach closed 4 months ago
Am I wrong in thinking that the "I did a full batch run using the batch command line argument" checkbox was added to ensure that the author of any change that touches the framework ran a batch test themselves before pushing a change for review?
I realize that this only has a small change to the framework, but surely just leaving the checkbox unchecked wasn't the intention when it was added.
Exactly. That's what the checkbox is meant for (we discussed this during the last call). But the PR (#1025) that added this was merged prematurely and I have no way of reverting that. Right now batch mode will probably crash at some point as some samples still need to be fixed or until #1036 is merged.
Description
Introduces a new Vulkan-Hpp-based sample, which is a transcoded version of the oit_depth_peeling api sample.
Build tested on Win10 with VS2022. Run tested on Win10 with NVidia GPU.
General Checklist:
Please ensure the following points are checked:
[x] This PR describes the scope and expected impact of the changes I am making
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batch
command line argument to make sure all samples still work properlySample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: