Fix requested_stats_count value cause no performance counters working

Assert-Backslash commented 5 months ago

Description

I found out that all HWCPipe counters not working when I downloaded the newest vulkan samples, and then i found out why and fixed it. wrong fixed

Fixes #1053

General Checklist:

Please ensure the following points are checked:

[x] My code follows the coding style
[x] I have reviewed file licenses
[x] I have commented any added functions (in line with Doxygen)
[x] I have commented any code that could be hard to understand
[x] My changes do not add any new compiler warnings
[x] My changes do not add any new validation layer errors or warnings
[x] I have used existing framework/helper functions where possible
[x] My changes do not add any regressions
[x] I have tested every sample to ensure everything runs correctly
[x] This PR describes the scope and expected impact of the changes I am making

Note: The Samples CI runs a number of checks including:
- [ ] I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
- [ ] My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions
If this PR contains framework changes:
- [ ] I did a full batch run using the batch command line argument to make sure all samples still work properly

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

[ ] I have tested the sample on at least one compliant Vulkan implementation
[ ] If the sample is vendor-specific, I have tagged it appropriately
[ ] I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
[ ] Any dependent assets have been merged and published in downstream modules
[ ] For new samples, I have added a paragraph with a summary to the appropriate chapter in the readme of the folder that the sample belongs to e.g. api samples readme
[ ] For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
[ ] For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

Assert-Backslash commented 5 months ago

Of course. I will handle this next Monday :)

程沛楠 TECH-图形引擎组-Rendering Engine | 图形引擎开发工程师-Rendering Engine Programmer

[image] BOOMING TECH | 不鸣科技 www.boomingtech.comhttp://www.boomingtech.com/

From: @.> Date: Thu, May 23, 2024, 23:26 Subject: Re: [KhronosGroup/Vulkan-Samples] Fix requested_stats_count value cause no performance counters working (PR #1055) To: @.> Cc: @.>, @.>

@JoseEmilio-ARM approved this pull request. Thank you very much! Would you be able to also rename requested_stats_count to stat_data_count? — Reply to this email directly, view it on GitHubhttps://github.com/KhronosGroup/Vulkan-Samples/pull/1055#pullrequestreview-2074328252, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKM3VCYWNMCWTMQFXM34XMLZDYDBXAVCNFSM6AAAAABIE2WC6GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANZUGMZDQMRVGI. You are receiving this because you authored the thread.[image: https://github.com/notifications/beacon/AKM3VC2N5G6FOSMZ3GZ6S53ZDYDBXA5CNFSM6AAAAABIE2WC6GWGG33NNVSW45C7OR4XAZNRKB2WY3CSMVYXKZLTORJGK5TJMV32UY3PNVWWK3TUL5UWJTT3UO6LY.gif]Message ID: @.***> 保密提示：本邮件及其任何附件具有保密性质，并可能受其他保护不允许被披露给第三方。如阁下误收到本邮件，敬请立即以回复电子邮件的方式通知发信人，并将本邮件及其任何附件从阁下系统中予以删除。如阁下并非本邮件写明之收件人，敬请切勿使用、复制、披露本邮件或其任何内容，亦请切勿依本邮件或其任何内容而采取任何行动。多谢合作！ CONFIDENTIALITY CAUTION: This email or the attachments therein are solely intended for the recipient and may contain confidential and/or privileged information. If it has reached you by mistake, please do not read, copy, save, forward or disseminate it to anyone else. We would appreciate it if you could delete it from your system and inform us by returning this email. Thank you.

Assert-Backslash commented 5 months ago

I have already renamed requested_stats_count to stat_data_count ^_^

tomadamatkinson commented 5 months ago

Approved from a code standpoint. Can't test on android at the moment!

KhronosGroup / Vulkan-Samples