KhronosGroup / Vulkan-Samples

One stop solution for all Vulkan samples
Apache License 2.0
4.33k stars 647 forks source link

Introduce type aliases for vkb::VulkanSample and vkb::core::VulkanResource. #1085

Closed asuessenbach closed 4 months ago

asuessenbach commented 4 months ago

Description

Introduces type aliases VulkanSample[C|Cpp] and VulkanResource[C|Cpp].

Build tested on Win10 with VS2022. Run tested on Win10 with NVidia GPU.

General Checklist:

Please ensure the following points are checked:

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

asuessenbach commented 4 months ago

The "Initialize containers" step in the Clang Format Check fails!

No idea how to resolve that.

SaschaWillems commented 4 months ago

Either a downtime or something related to the current rework of Khronos CI. If this isn't working in a few hours, days, maybe ping James (Khronos Webmaster).

asuessenbach commented 4 months ago

But I think should also update the smaple templates to use the new aliases, see https://github.com/KhronosGroup/Vulkan-Samples/tree/main/bldsys/cmake/template/sample_api and https://github.com/KhronosGroup/Vulkan-Samples/tree/main/bldsys/cmake/template/sample

Good point!

... and done.

marty-johnson59 commented 4 months ago

Merging per discussion yesterday. Thanks Gary!