KhronosGroup / Vulkan-Samples

One stop solution for all Vulkan samples
Apache License 2.0
4.23k stars 634 forks source link

Update path to vulkan_samples.app in MacOS #1112

Closed chmosquera closed 2 months ago

chmosquera commented 2 months ago

Description

Adjusted the instructions for building to MacOS by correcting the folder name where the application is built to.

Since the change is a minor instructional update, I did not do any code or build checks. However, I did verify that the command does what's expected: call the application --help command.

General Checklist:

Please ensure the following points are checked:

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

CLAassistant commented 2 months ago

CLA assistant check
All committers have signed the CLA.

SRSaunders commented 2 months ago

See item 7 in pending pull request #1084. I am proposing to revert to a macOS command line app vs. an app bundle since it is not required for this project (other than for iOS). In addition, this PR also contains a change to the docs (https://github.com/KhronosGroup/Vulkan-Samples/pull/1084/commits/53212364e2acf98d9a5732b84533325d8890b2af) for <arm64|x86_64> path options.

chmosquera commented 2 months ago

Thanks for letting me know! In that case, we can probably close this PR. It seems like with the two PRs mentioned above, this change won't be needed.

SRSaunders commented 2 months ago

Thanks for reviewing and looking into this.