Fixes to iOS render loop and HUD overlay.

[billhollings]

• Refactor Platform::main_loop_frame() and main_loop(), to reduce fragility, and avoid unnecessary code duplication.

• Avoid initial app_requested() test in main_loop_frame(), as it was causing looping to stop after one frame.

• Since main_loop() is not a virtual function, remove declaration comment indicating it can be overridden.

• Set iOS view to have a black background, to ensure transparency in HUD overlay displays in full on device.

• Fix rendering scaling in IosWindow::get_dpi_factor(). Previous value was causing HUD overlay to render magnitudes too large.

• Add macOS files to .gitignore.

I created this from a branch on this repo instead of a separate fork, because I was not expecting to need to make a fix.

Fixes #1121 Fixes #1131

General Checklist:

Please ensure the following points are checked:

• [x] My code follows the coding style
• [x] I have reviewed file licenses
• [x] I have commented any added functions (in line with Doxygen)
• [x] I have commented any code that could be hard to understand
• [x] My changes do not add any new compiler warnings
• [x] My changes do not add any new validation layer errors or warnings
• [x] I have used existing framework/helper functions where possible
• [x] My changes do not add any regressions
• [ ] I have tested every sample to ensure everything runs correctly

• [x] This PR describes the scope and expected impact of the changes I am making

  Note: The Samples CI runs a number of checks including:

  • [x] I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • [x] My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

  If this PR contains framework changes:

  • [ ] I did a full batch run using the batch command line argument to make sure all samples still work properly

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

• [ ] I have tested the sample on at least one compliant Vulkan implementation
• [ ] If the sample is vendor-specific, I have tagged it appropriately
• [ ] I have stated on what implementation the sample has been tested so that others can test on different implementations and platforms
• [ ] Any dependent assets have been merged and published in downstream modules
• [ ] For new samples, I have added a paragraph with a summary to the appropriate chapter in the readme of the folder that the sample belongs to e.g. api samples readme
• [ ] For new samples, I have added a tutorial README.md file to guide users through what they need to know to implement code using this feature. For example, see conditional_rendering
• [ ] For new samples, I have added a link to the Antora navigation so that the sample will be listed at the Vulkan documentation site

[asuessenbach]

You should at least resolve the failing Quality Check.

[billhollings]

You should at least resolve the failing Quality Check.

If tried many times.

1. For some reason, clang-format works slightly differently on macOS than on other platforms, so running ./scripts/clang_format.py main ends up changing more than expected, and breaks the CI test here.
2. The CI error messages are incomprehensible to me, so I'm not able to decipher what it's complaining about, in order to simply fix it manually.

[gpx1000]

https://github.com/KhronosGroup/Vulkan-Samples/actions/runs/10461719961?pr=1120

If you scroll to the bottom you can grab the diff that can be directly run and hopefully fix the issue.

[asuessenbach]

For some reason, clang-format works slightly differently on macOS than on other platforms

Indeed, it should remove white spaces at the end of a line, and it should replace spaces with tabs. This patch shows the difference I would get when running clang-format: 0001-formatting.patch

[billhollings]

@gpx1000 @asuessenbach

Thanks for the help on code formatting. I've got this formatting correctly now.

Plus I've added a couple of other iOS fixes, and updated the title and description above.

[billhollings]

LGTM. Did full batch runs for iOS + macOS and both main_loop_frame() and main_loop() worked correctly. Still need fixes for non-success return codes in iOS viewDidLoad() and renderLoop(), but these can be dealt with in a future PR.

@SRSaunders Would you mind giving this a formal approval, so it can be merged, please?

Once the approvals are in, what is the process for merging? Do I do that? Or is there a designated person responsible for merging?

[gpx1000]

We usually ask @marty-johnson59 to handle the merging. We usually merge on 3; but Marty, I think this is safe to merge on 2.

[SRSaunders]

@SRSaunders Would you mind giving this a formal approval, so it can be merged, please?

@billhollings I don't have approval rights for this project. I am happy to provide feedback, but I cannot mark the PR as ready for merge. As you see above, @gpx1000 has that ability.

[marty-johnson59]

Thanks. Given this is Mac (we have limited folks who can test), I'm happy to merge w/ 2. We can revert if needed.