search

KhronosGroup / Vulkan-Samples

One stop solution for all Vulkan samples
Apache License 2.0
4.36k stars 650 forks source link

Missing feature checks cause sample crashes on Windows 10 + AMD GPU #1144

Closed SRSaunders closed 1 month ago

SRSaunders commented 2 months ago

Crashes in vkCreateDevice() occur with the following samples when running on Windows 10 with an AMD 6600XT GPU:

  1. _dynamic_linerasterization
  2. _extended_dynamicstate2
  3. _logic_op_dynamicstate
  4. _patch_controlpoints

The crashes appear to be due to missing dynamic state and/or line rasterization feature support which is requested by the samples and part of the VkDeviceCreateInfo struct. This seems a bit unexpected, as vkCreateDevice() should be able to handle this and instead return a non-success error code. However, this does not seem to be the case at least for my graphics card/driver. I am using the most up-to-date AMD drivers and Vulkan SDK 1.3.290. Windows 10 is also up to date.

I will post a PR that first checks for the required features in the above samples and avoids the crashes.

jeroenbakker-atmind commented 1 month ago

I will check if this is still an issue. There has been some improvements in querying the features. Validation if all these issues have been solved needs to be done.

SRSaunders commented 1 month ago

I have retested and #1013 fixes this issue for me. @jeroenbakker-atmind if your tests also pass I will close this issue as complete. Please let me know.

jeroenbakker-atmind commented 1 month ago

Yes it was fixed by the mentioned PR