search

KhronosGroup / Vulkan-Samples

One stop solution for all Vulkan samples
Apache License 2.0
4.36k stars 650 forks source link

struct HPPVertex missing glm::vec3 color member in hpp_api_vulkan_sample.h #1161

Closed SRSaunders closed 2 months ago

SRSaunders commented 2 months ago

Commit d0fda1b added member glm::vec3 color to the Vertex struct in api_vulkan_sample.h. However, the corresponding HPPVertex struct is now missing the same entry in hpp_api_vulkan_sample.h. It's likely just an oversight, but causes a bunch of problems for hpp samples as can be seen below:

Screenshot 2024-09-11 at 10 59 06 AM

SaschaWillems commented 2 months ago

Tbh. as someone adding new samples I always have a hard time getting things right with having so much code duplicated as C/C++. The odd thing is that I did a full batch run back then and didn't notice any problems.

I think we should move that struct to a central place and deduplicate it to avoid such problems in the future.

asuessenbach commented 2 months ago

I think we should move that struct to a central place and deduplicate it to avoid such problems in the future.

Agreed, that would be the best solution. Someone has to do it... With #1162, we have a quick fix on the current situation, though. Should merge that soon.