Closed burak-efe closed 1 month ago
I think, you should mention the additional changes in .gitignore
and std_filesystem.cpp
in the Description section above. Or maybe just move them into a separate PR.
I second that. When I reviewed, it only had the documentation fix (which is fine). But a recent commit also changed code. Can you please revert that?
I second that. When I reviewed, it only had the documentation fix (which is fine). But a recent commit also changed code. Can you please revert that?
Oh my bad, I was planning these for another request, I reverted that. It should be good now, sorry about that.
Description
remove duplicate text
General Checklist:
Please ensure the following points are checked:
[x] This PR describes the scope and expected impact of the changes I am making
Note: The Samples CI runs a number of checks including:
If this PR contains framework changes:
batch
command line argument to make sure all samples still work properly