KhronosGroup / Vulkan-Samples

One stop solution for all Vulkan samples
Apache License 2.0
4.19k stars 625 forks source link

FI: Move CLI Parsing Framework into a Separate Library #439

Closed TomAtkinsonArm closed 1 week ago

TomAtkinsonArm commented 2 years ago

What is the Problem?

Not so much a problem at the moment but if the platform class is removed with #438 then the CLI Parsing should be moved to event handlers which take in reference to all resources they modify. At the moment the platform triages all.

What is the proposed Solution?

Port Plugins to the new framework paradigm

Examples

in main(){
  EventBus bus;

  PluginSet plugins;
  plugins.add(SomePluginWhichChangesTheWindow(window));
  plugins.add(SomePluginWhichControlsLogging());

  bus.import(plugins.handlers());
}

Issues

SaschaWillems commented 3 months ago

With the mentioned #438 having been closed some time ago, do we still need/want this?

SaschaWillems commented 1 week ago

Closing this for now. I don't think we're going to implement this.