Fix for crashes caused by hpp interface differences

[gary-sweet]

Description

There is a difference in interfaces between DebugUtils and HPPDebugUtils introduced by https://github.com/KhronosGroup/Vulkan-Samples/pull/788

DebugUtils accepts the color argument as glm::vec4 const color whereas HPPDebugUtils takes a reference instead. This ends up causing a color of <0,0,0,0> being reinterpreted as a reference, which doesn't end well.

This change makes the HPPDebugUtils interface match DebugUtils again.

Fixes #817

General Checklist:

Please ensure the following points are checked:

• [x] My code follows the coding style
• [x] I have reviewed file licenses
• [x] I have commented any added functions (in line with Doxygen)
• [x] I have commented any code that could be hard to understand
• [x] My changes do not add any new compiler warnings
• [x] My changes do not add any new validation layer errors or warnings
• [x] I have used existing framework/helper functions where possible
• [x] My changes do not add any regressions
• [ ] I have tested every sample to ensure everything runs correctly

• [x] This PR describes the scope and expected impact of the changes I am making

  Note: The Samples CI runs a number of checks including:

  • [x] I have updated the header Copyright to reflect the current year (CI build will fail if Copyright is out of date)
  • [ ] My changes build on Windows, Linux, macOS and Android. Otherwise I have documented any exceptions

[marty-johnson59]

Merging - 3 approvals