Closed asuessenbach closed 6 months ago
Can we discuss this in the next samples call? The PR itself is fine, but it has a lot of framework changes and I'm unsure how these align with the framework direction we recently talked about.
Can we discuss this in the next samples call?
Sure, but I can't attend the next call. Will be back again next year.
@gary-sweet What compiler are you using? Obviously, the compilers in our CI are less picky. Maybe we should add that compiler to our CI? That said, would you please try again if my latest change resolves those errors?
@gary-sweet What compiler are you using? Obviously, the compilers in our CI are less picky. Maybe we should add that compiler to our CI? That said, would you please try again if my latest change resolves those errors?
I'm not sure how but I completely missed your reply somehow. Apologies for that. Sadly the latest changes haven't changed the compile errors.
The compiler is "gcc version 8.3.0 (stbgcc-8.3-1.0) " for aarch64
Closed for now, as the C/Cpp unification takes a different path.
Description
Includes
struct [HPP]Meshlet
in[hpp_]api_vulkan_sample.h
;common/hpp_utils.h
;is_image_format_supported
inHPPPhysicalDevice
, that catches the exception thrown on not supported formats;GLTFLoader
andscene_graph::Scene
scene_graph/component
classes inHPPVulkanSample
andrendering::subpasses::HPPForwardSubpass
;scene_graph::components::HPPCamera
,scene_graph::components::HPPLight
,scene_graph::components::HPPMesh
,scene_graph::components::HPPPBRMaterial
,scene_graph::components::HPPSampler
,scene_graph::components::HPPTexture
,scene_graph::components::HPPTransform
,scene_graph::HPPNode
,scene_graph::HPPScene
, andscene_graph::scripts::HPPAnimation
scene_graph::components::HPPImage
andscene_graph::components::HPPSubMesh
scene_graph::components::HPPPerspectiveCamera
andscene_graph::components::image::HPPAstc
gshader_to_mshader.mesh
.Build tested on Win10 with VS2022. All hpp-based samples tested on Win10 with NVidia GPU.
General Checklist:
Please ensure the following points are checked:
[x] This PR describes the scope and expected impact of the changes I am making
Note: The Samples CI runs a number of checks including:
Sample Checklist
If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist: