KhronosGroup / Vulkan-Samples

One stop solution for all Vulkan samples
Apache License 2.0
4.34k stars 648 forks source link

Change vkb::HPPGLTFLoader from a facade over vkb::GLTFLoader to a self-contained class using Vulkan-Hpp. #861

Closed asuessenbach closed 6 months ago

asuessenbach commented 11 months ago

Description

Includes

Build tested on Win10 with VS2022. All hpp-based samples tested on Win10 with NVidia GPU.

General Checklist:

Please ensure the following points are checked:

Sample Checklist

If your PR contains a new or modified sample, these further checks must be carried out in addition to the General Checklist:

SaschaWillems commented 11 months ago

Can we discuss this in the next samples call? The PR itself is fine, but it has a lot of framework changes and I'm unsure how these align with the framework direction we recently talked about.

asuessenbach commented 11 months ago

Can we discuss this in the next samples call?

Sure, but I can't attend the next call. Will be back again next year.

asuessenbach commented 10 months ago

@gary-sweet What compiler are you using? Obviously, the compilers in our CI are less picky. Maybe we should add that compiler to our CI? That said, would you please try again if my latest change resolves those errors?

gary-sweet commented 9 months ago

@gary-sweet What compiler are you using? Obviously, the compilers in our CI are less picky. Maybe we should add that compiler to our CI? That said, would you please try again if my latest change resolves those errors?

I'm not sure how but I completely missed your reply somehow. Apologies for that. Sadly the latest changes haven't changed the compile errors.

The compiler is "gcc version 8.3.0 (stbgcc-8.3-1.0) " for aarch64

asuessenbach commented 6 months ago

Closed for now, as the C/Cpp unification takes a different path.