Closed jherico closed 8 months ago
The quality check action every time I push:
There are a few scripts that help there ./scripts/clang_format.py main
and ./scripts/copyright.py main
. They do help provide a base level of standardisation to the project. Open to ideas on how to improve them. Maybe moving to pre-commit?
Merging - 3 approvals
Description
This updates the VMA submodule commit to the one tagged as release version 3.0.1, and makes changes to the codebase to account for the difference in the VMA API between the prior 3.0.0-dev version and the current release version. In particular
vkGetXXXProcAddress
functionsVMA_ALLOCATION_CREATE_MAPPED_BIT
doesn't guarantee mappable memory unless combined withVMA_ALLOCATION_CREATE_HOST_ACCESS_RANDOM_BIT
orVMA_ALLOCATION_CREATE_HOST_ACCESS_SEQUENTIAL_WRITE_BIT
, so the default flags for the Buffer types are correspondingly updatedvmaCalculateStats
function is nowvmaCalculateStatistics
and the result structure is slightly changed<VMA_DIR>/src
to<VMA_DIR>/include
. In order to suppress a large number of clang-tidy warnings from the header, the include path has now been marked asSYSTEM
in CMake.Fixes #899
General Checklist:
Please ensure the following points are checked:
[X] This PR describes the scope and expected impact of the changes I am making
Note: The Samples CI runs a number of checks including: