KhronosGroup / Vulkan-Samples

One stop solution for all Vulkan samples
Apache License 2.0
4.33k stars 648 forks source link

fragment_shading_rate_dynamic crashes #913

Closed jherico closed 6 months ago

jherico commented 9 months ago

Building from main on Windows 10 (MSVC 2022) the fragment_shading_rate_dynamic sample currently crashes after a set of validation errors.

Output after swap chain setup is as follows:

UNASSIGNED-GeneralParameterError-ExtensionNotEnabled(ERROR / SPEC): msgNum: -383040211 - Validation Error: [ UNASSIGNED-GeneralParameterError-ExtensionNotEnabled ] Object 0: handle = 0x2321cce5530, type = VK_OBJECT_TYPE_INSTANCE; | MessageID = 0xe92b452d | Attempted to call vkCmdSetFragmentShadingRateKHR() but its required extension VK_VERSION_1_1 has not been enabled

    Objects: 1
        [0] 0x2321cce5530, type: 1, name: NULL
UNASSIGNED-GeneralParameterError-ExtensionNotEnabled(ERROR / SPEC): msgNum: -383040211 - Validation Error: [ UNASSIGNED-GeneralParameterError-ExtensionNotEnabled ] Object 0: handle = 0x2321cce5530, type = VK_OBJECT_TYPE_INSTANCE; | MessageID = 0xe92b452d | Attempted to call vkCmdSetFragmentShadingRateKHR() but its required extension VK_VERSION_1_2 has not been enabled

    Objects: 1
        [0] 0x2321cce5530, type: 1, name: NULL
UNASSIGNED-GeneralParameterError-ExtensionNotEnabled(ERROR / SPEC): msgNum: -383040211 - Validation Error: [ UNASSIGNED-GeneralParameterError-ExtensionNotEnabled ] Object 0: handle = 0x2321cce5530, type = VK_OBJECT_TYPE_INSTANCE; | MessageID = 0xe92b452d | Attempted to call vkCmdSetFragmentShadingRateKHR() but its required extension VK_VERSION_1_1 has not been enabled

    Objects: 1
        [0] 0x2321cce5530, type: 1, name: NULL
UNASSIGNED-GeneralParameterError-ExtensionNotEnabled(ERROR / SPEC): msgNum: -383040211 - Validation Error: [ UNASSIGNED-GeneralParameterError-ExtensionNotEnabled ] Object 0: handle = 0x2321cce5530, type = VK_OBJECT_TYPE_INSTANCE; | MessageID = 0xe92b452d | Attempted to call vkCmdSetFragmentShadingRateKHR() but its required extension VK_VERSION_1_2 has not been enabled

    Objects: 1
        [0] 0x2321cce5530, type: 1, name: NULL
UNASSIGNED-GeneralParameterError-ExtensionNotEnabled(ERROR / SPEC): msgNum: -383040211 - Validation Error: [ UNASSIGNED-GeneralParameterError-ExtensionNotEnabled ] Object 0: handle = 0x2321cce5530, type = VK_OBJECT_TYPE_INSTANCE; | MessageID = 0xe92b452d | Attempted to call vkCmdSetFragmentShadingRateKHR() but its required extension VK_VERSION_1_1 has not been enabled

    Objects: 1
        [0] 0x2321cce5530, type: 1, name: NULL
UNASSIGNED-GeneralParameterError-ExtensionNotEnabled(ERROR / SPEC): msgNum: -383040211 - Validation Error: [ UNASSIGNED-GeneralParameterError-ExtensionNotEnabled ] Object 0: handle = 0x2321cce5530, type = VK_OBJECT_TYPE_INSTANCE; | MessageID = 0xe92b452d | Attempted to call vkCmdSetFragmentShadingRateKHR() but its required extension VK_VERSION_1_2 has not been enabled

    Objects: 1
        [0] 0x2321cce5530, type: 1, name: NULL
UNASSIGNED-GeneralParameterError-ExtensionNotEnabled(ERROR / SPEC): msgNum: -383040211 - Validation Error: [ UNASSIGNED-GeneralParameterError-ExtensionNotEnabled ] Object 0: handle = 0x2321cce5530, type = VK_OBJECT_TYPE_INSTANCE; | MessageID = 0xe92b452d | Attempted to call vkCmdSetFragmentShadingRateKHR() but its required extension VK_VERSION_1_1 has not been enabled

    Objects: 1
        [0] 0x2321cce5530, type: 1, name: NULL
UNASSIGNED-GeneralParameterError-ExtensionNotEnabled(ERROR / SPEC): msgNum: -383040211 - Validation Error: [ UNASSIGNED-GeneralParameterError-ExtensionNotEnabled ] Object 0: handle = 0x2321cce5530, type = VK_OBJECT_TYPE_INSTANCE; | MessageID = 0xe92b452d | Attempted to call vkCmdSetFragmentShadingRateKHR() but its required extension VK_VERSION_1_2 has not been enabled

    Objects: 1
        [0] 0x2321cce5530, type: 1, name: NULL
UNASSIGNED-GeneralParameterError-ExtensionNotEnabled(ERROR / SPEC): msgNum: -383040211 - Validation Error: [ UNASSIGNED-GeneralParameterError-ExtensionNotEnabled ] Object 0: handle = 0x2321cce5530, type = VK_OBJECT_TYPE_INSTANCE; | MessageID = 0xe92b452d | Attempted to call vkCmdSetFragmentShadingRateKHR() but its required extension VK_VERSION_1_1 has not been enabled

    Objects: 1
        [0] 0x2321cce5530, type: 1, name: NULL
UNASSIGNED-GeneralParameterError-ExtensionNotEnabled(ERROR / SPEC): msgNum: -383040211 - Validation Error: [ UNASSIGNED-GeneralParameterError-ExtensionNotEnabled ] Object 0: handle = 0x2321cce5530, type = VK_OBJECT_TYPE_INSTANCE; | MessageID = 0xe92b452d | Attempted to call vkCmdSetFragmentShadingRateKHR() but its required extension VK_VERSION_1_2 has not been enabled

    Objects: 1
        [0] 0x2321cce5530, type: 1, name: NULL
VUID-vkQueueSubmit-pCommandBuffers-00070(ERROR / SPEC): msgNum: -1360208885 - Validation Error: [ VUID-vkQueueSubmit-pCommandBuffers-00070 ] Object 0: handle = 0x2322a8bbdf0, type = VK_OBJECT_TYPE_COMMAND_BUFFER; | MessageID = 0xaeecdc0b | VkCommandBuffer 0x2322a8bbdf0[] used in the call to vkQueueSubmit is unrecorded and contains no commands. The Vulkan spec states: Each element of the pCommandBuffers member of each element of pSubmits must be in the pending or executable state (https://vulkan.lunarg.com/doc/view/1.3.243.0/windows/1.3-extensions/vkspec.html#VUID-vkQueueSubmit-pCommandBuffers-00070)
    Objects: 1
        [0] 0x2322a8bbdf0, type: 6, name: NULL
jherico commented 9 months ago

Git bisect suggests that it broke with this commit: https://github.com/KhronosGroup/Vulkan-Samples/commit/e48cc9e22210fcbea93544d7e075e57f5967a3f5#diff-185d206698381bf0a1ad21ce477b6ccda43f9e7debc6d304cc2ba5aadde91f1e

SaschaWillems commented 7 months ago

Can you recheck? The sample works fine for me and I get no validation errors with the latest SDK. The layer messages seem like false positives as VK_KHR_fragment_shading_rate shouldn't require VK 1.1 or 1.2.

SaschaWillems commented 6 months ago

Checked with the latest SDK 1.3.283, and I see no validation errors and no crashes. So closing this for now.