KhronosGroup / Vulkan-Samples

One stop solution for all Vulkan samples
Apache License 2.0
4.33k stars 648 forks source link

Fix validation errors about using unsupported linear filtering #924

Closed gary-sweet closed 8 months ago

gary-sweet commented 9 months ago

Description

Most of the samples, and parts of the framework, just build samplers using linear filtering and mipmap-modes. This is only guaranteed to be supported for a handful of formats. On my hardware this results in a large number of validation errors.

Fixes #923

General Checklist:

Please ensure the following points are checked:

gary-sweet commented 8 months ago

Sorry, needed to rebase to resolve merge conflicts.

gary-sweet commented 8 months ago

Sorry, I needed to rebase this due to merge conflicts in mobile_nerf.cpp

gary-sweet commented 8 months ago

Rebased again after yesterday's merges caused more conflicts

gary-sweet commented 8 months ago

More merge conflicts I'll need to look at again - sigh.

I can't seem to get this past 2 approvals before someone else merges something.

SaschaWillems commented 8 months ago

That's annoying.

@marty-johnson59 : I don't think we need three approvals on this. It's just a bugfix and the code is perfectly fine. Can we merge once Gary has fixed the current merge conflicts?

gary-sweet commented 8 months ago

@marty-johnson59 : I don't think we need three approvals on this. It's just a bugfix and the code is perfectly fine. Can we merge once Gary has fixed the current merge conflicts?

Thanks Sascha, that would be great if possible.

marty-johnson59 commented 8 months ago

OK, I'll merge. LMK if this causes problems.