Closed gary-sweet closed 8 months ago
Sorry, needed to rebase to resolve merge conflicts.
Sorry, I needed to rebase this due to merge conflicts in mobile_nerf.cpp
Rebased again after yesterday's merges caused more conflicts
More merge conflicts I'll need to look at again - sigh.
I can't seem to get this past 2 approvals before someone else merges something.
That's annoying.
@marty-johnson59 : I don't think we need three approvals on this. It's just a bugfix and the code is perfectly fine. Can we merge once Gary has fixed the current merge conflicts?
@marty-johnson59 : I don't think we need three approvals on this. It's just a bugfix and the code is perfectly fine. Can we merge once Gary has fixed the current merge conflicts?
Thanks Sascha, that would be great if possible.
OK, I'll merge. LMK if this causes problems.
Description
Most of the samples, and parts of the framework, just build samplers using linear filtering and mipmap-modes. This is only guaranteed to be supported for a handful of formats. On my hardware this results in a large number of validation errors.
Fixes #923
General Checklist:
Please ensure the following points are checked:
[x] This PR describes the scope and expected impact of the changes I am making
Note: The Samples CI runs a number of checks including: