KhronosGroup / Vulkan-Samples

One stop solution for all Vulkan samples
Apache License 2.0
4.33k stars 648 forks source link

Add HLSL shaders and improve tooling #961

Closed SaschaWillems closed 5 months ago

SaschaWillems commented 8 months ago

Description

With the framework now being able to consume shaders in SPIR-V format, this PR will start adding actual HLSL shaders to the repository for at least some samples. I'll be starting with adding HLSL shaders to my samples and maybe other not so complex samples.

✅ What this PR currently does:

📃List of samples that got HLSL shaders added

For a complete list of samples see #1014 This PR adds HLSL shaders (based on their GLSL counterparts) for the following samples:

❌ What this won't do

💬Up for discussion

🚧Opens

Fixes #892 Fixes #179

General Checklist:

Please ensure the following points are checked:

SaschaWillems commented 7 months ago

Quick note: While adding HLSL shaders I noticed that several samples are broken on main or at least display validation errors. So when reviewing, most errors that show up are probably also visible on main. I didn't want to fix it in order not to pollute this PR.

JoseEmilio-ARM commented 5 months ago

Quick note: While adding HLSL shaders I noticed that several samples are broken on main or at least display validation errors. So when reviewing, most errors that show up are probably also visible on main. I didn't want to fix it in order not to pollute this PR.

Tested most samples and found no issues, sorry for the delay. I did notice that Performance/WaitIdle does not launch on Android. I thought it was unrelated, but the same sample opens fine in #1051 , maybe it's an issue from a commit in between the two?

SaschaWillems commented 5 months ago

I did notice that Performance/WaitIdle does not launch on Android. I thought it was unrelated

That is indeed unrelated to this PR. That sample was broken on master for quite some time and was fixed by a different PR that I haven't merged. So it shouldn't matter for this PR :)