KhronosGroup / Vulkan-Samples

One stop solution for all Vulkan samples
Apache License 2.0
4.33k stars 648 forks source link

Precommit formatting is applied to non-source files #997

Closed SaschaWillems closed 5 months ago

SaschaWillems commented 7 months ago

I just wanted to push a very minor documentation fix, but with precommit from #939 enabled all I got when trying to push was this cryptic error:

image

I noticed that I had a new commit in my changes that removed some trailing spaces, something I didn't touch on and didn't want to change.

What's problematic about this is that git didn't let me push my actual change without also pushing the precommit fix.

To get around this I had to uninstall precommit.

Maybe we should exclude non-source files from precommit (if that's actually possible)?