search

KhronosGroup / Vulkan-Tools

Vulkan Development Tools
Apache License 2.0
361 stars 153 forks source link

vkcube: Thread safe event polling #978

Closed HildarTheDorf closed 5 months ago

HildarTheDorf commented 5 months ago

The fix for #976 has a couple of flaws, I think. 1) The poll is unnecessary as we have an always-running main loop, it's okay to do an empty read, it won't block. 2) If the driver uses multiple threads internally, we are not guarding against a concurrent read by the driver. 3) We never flush messages to the server. Again, the driver could send messages and expect the application to flush.

Both 2) and 3) assume a sufficiently naive driver, most are more defensive than the bare minimum.

ci-tester-lunarg commented 5 months ago

Author HildarTheDorf not on autobuild list. Waiting for curator authorization before starting CI build.

ci-tester-lunarg commented 5 months ago

Author HildarTheDorf not on autobuild list. Waiting for curator authorization before starting CI build.

ci-tester-lunarg commented 5 months ago

CI Vulkan-Tools build queued with queue ID 158346.

ci-tester-lunarg commented 5 months ago

CI Vulkan-Tools build # 1409 running.

ci-tester-lunarg commented 5 months ago

CI Vulkan-Tools build # 1409 passed.

ci-tester-lunarg commented 5 months ago

Author HildarTheDorf not on autobuild list. Waiting for curator authorization before starting CI build.

ci-tester-lunarg commented 5 months ago

Author HildarTheDorf not on autobuild list. Waiting for curator authorization before starting CI build.

ci-tester-lunarg commented 5 months ago

CI Vulkan-Tools build queued with queue ID 158373.

ci-tester-lunarg commented 5 months ago

CI Vulkan-Tools build # 1410 running.

ci-tester-lunarg commented 5 months ago

CI Vulkan-Tools build # 1410 passed.