search

KhronosGroup / Vulkan-ValidationLayers

Vulkan Validation Layers (VVL)
https://vulkan.lunarg.com/doc/sdk/latest/linux/khronos_validation_layer.html
Other
760 stars 403 forks source link

Fix unexpected messages Android #4673

Closed juan-lunarg closed 1 year ago

juan-lunarg commented 2 years ago

Describe the Issue Currently unexpected messages aren't treated as errors on Android, but are treated as errors for other platforms: https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/4570#discussion_r997423074

Environment:

Additional context To work on issue remove Android exception created for https://github.com/KhronosGroup/Vulkan-ValidationLayers/commit/9f4f9e0d7ca2b81dd2d77745f1f76d1c8e6d881c

IE:

            // TODO: Fix unexpected android failures
#if !defined(ANDROID)
            ADD_FAILURE() << "Received unexpected error.";
#endif
juan-lunarg commented 1 year ago

Current failing tests when validation is enforced as errors on Android:

GalaxyS10

[  FAILED  ] 2 tests, listed below:
[  FAILED  ] VkLayerTest.CreateImageMiscErrors
[  FAILED  ] VkBestPracticesLayerTest.UseDeprecatedInstanceExtensions

GalaxyS22

[  FAILED  ] 9 tests, listed below:
[  FAILED  ] VkLayerTest.InvalidProtectedQueue
[  FAILED  ] VkLayerTest.AndroidHardwareBufferDedicatedUsageDS
[  FAILED  ] VkLayerTest.AndroidHardwareBufferImportBufferHandleType
[  FAILED  ] VkLayerTest.RayTracingPipelineCreateInfoKHR
[  FAILED  ] VkLayerTest.RayTracingPipelineShaderGroupsKHR
[  FAILED  ] VkLayerTest.RayTracingInvalidPipelineFlags
[  FAILED  ] VkBestPracticesLayerTest.UseDeprecatedInstanceExtensions
[  FAILED  ] VkPositiveLayerTest.AndroidHardwareBufferMemoryRequirements
[  FAILED  ] VkPositiveLayerTest.AndroidHardwareBufferDepthStencil

Pixel 3

[  FAILED  ] 1 test, listed below:
[  FAILED  ] VkBestPracticesLayerTest.UseDeprecatedInstanceExtensions

Pixel 6

[  FAILED  ] 3 tests, listed below:
[  FAILED  ] VkLayerTest.CreateImageMiscErrors
[  FAILED  ] VkLayerTest.AndroidHardwareBufferDedicatedUsageDS
[  FAILED  ] VkBestPracticesLayerTest.UseDeprecatedInstanceExtensions

SheildTV

[  FAILED  ] 2 tests, listed below:
[  FAILED  ] VkBestPracticesLayerTest.UseDeprecatedInstanceExtensions
[  FAILED  ] VkSyncValTest.SyncQSPresentAcquire