search

KhronosGroup / Vulkan-ValidationLayers

Vulkan Validation Layers (VVL)
https://vulkan.lunarg.com/doc/sdk/latest/linux/khronos_validation_layer.html
Other
751 stars 403 forks source link

layers: Use DeviceFeature helper instead of pNext checks #8118

Closed spencer-lunarg closed 3 months ago

spencer-lunarg commented 3 months ago

closes https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/8110 (with help of https://github.com/KhronosGroup/Vulkan-Utility-Libraries/pull/218)

We have this nice DeviceFeature that we fill so we can go enabled_features.someFeature

This removes all the stateless checks that were scanning the pNext and just uses this instead... which in turn doesn't create a 200+ callstack on deletion of the VkDevice

Another issue was the use of safe_VkDeviceCreateInfo which was used to allow GPU-AV / DebugPrintF to add features, this has been updated

ci-tester-lunarg commented 3 months ago

CI Vulkan-ValidationLayers build queued with queue ID 197962.

ci-tester-lunarg commented 3 months ago

CI Vulkan-ValidationLayers build # 16772 running.

ci-tester-lunarg commented 3 months ago

CI Vulkan-ValidationLayers build # 16772 passed.

ci-tester-lunarg commented 3 months ago

CI Vulkan-ValidationLayers build queued with queue ID 198299.

ci-tester-lunarg commented 3 months ago

CI Vulkan-ValidationLayers build # 16777 running.

ci-tester-lunarg commented 3 months ago

CI Vulkan-ValidationLayers build queued with queue ID 198311.

ci-tester-lunarg commented 3 months ago

CI Vulkan-ValidationLayers build # 16778 running.

ci-tester-lunarg commented 3 months ago

CI Vulkan-ValidationLayers build # 16778 passed.

ci-tester-lunarg commented 3 months ago

CI Vulkan-ValidationLayers build queued with queue ID 198395.

ci-tester-lunarg commented 3 months ago

CI Vulkan-ValidationLayers build # 16780 running.

ci-tester-lunarg commented 3 months ago

CI Vulkan-ValidationLayers build # 16780 passed.

ci-tester-lunarg commented 3 months ago

CI Vulkan-ValidationLayers build queued with queue ID 198423.

ci-tester-lunarg commented 3 months ago

CI Vulkan-ValidationLayers build # 16782 running.

ci-tester-lunarg commented 3 months ago

CI Vulkan-ValidationLayers build # 16782 failed.

ci-tester-lunarg commented 3 months ago

CI Vulkan-ValidationLayers build queued with queue ID 198463.

ci-tester-lunarg commented 3 months ago

CI Vulkan-ValidationLayers build # 16784 running.

ci-tester-lunarg commented 3 months ago

CI Vulkan-ValidationLayers build # 16784 passed.