search

KhronosGroup / Vulkan-ValidationLayers

Vulkan Validation Layers (VVL)
https://vulkan.lunarg.com/doc/sdk/latest/linux/khronos_validation_layer.html
Other
727 stars 396 forks source link

bp: Remove best_practices_error_enums.h #8143

Closed spencer-lunarg closed 3 weeks ago

spencer-lunarg commented 3 weeks ago

This removes best_practices_error_enums.h which was left there, grew, and has no good value

  1. The names in strings don't match up with the variable name
  2. Some of these were not ever used
  3. We should have an unique ID for each error, having many duplicates makes it hard to know where the error came from
  4. I always have to do a double look-up to find which test used it
ci-tester-lunarg commented 3 weeks ago

CI Vulkan-ValidationLayers build queued with queue ID 200015.

ci-tester-lunarg commented 3 weeks ago

CI Vulkan-ValidationLayers build # 16816 running.

ci-tester-lunarg commented 3 weeks ago

CI Vulkan-ValidationLayers build # 16816 passed.

ci-tester-lunarg commented 3 weeks ago

CI Vulkan-ValidationLayers build queued with queue ID 200252.

ci-tester-lunarg commented 3 weeks ago

CI Vulkan-ValidationLayers build # 16821 running.

ci-tester-lunarg commented 3 weeks ago

CI Vulkan-ValidationLayers build # 16821 passed.