gpu: Fix user push constants restore - and state tracking in Core validation

KhronosGroup / Vulkan-ValidationLayers

Vulkan Validation Layers (VVL)

https://vulkan.lunarg.com/doc/sdk/latest/linux/khronos_validation_layer.html

Other

727 stars 396 forks source link

gpu: Fix user push constants restore - and state tracking in Core validation #8149

Closed arno-lunarg closed 2 weeks ago

arno-lunarg commented 3 weeks ago

Push constants state restoration was not working correctly
Reworked the state tracking, also in best practices
Added 2 tests, RestorePushConstants is not working on my PC, vertex shader runs correctly but no fragment are emitted when doing an indirect draw. Things work as expected when doing a normal draw. It is not related to GPU-AV, as disabling it does not solve the problem. My indirect buffer looks ok, so I will see what CI tells me.

Will see if it closes https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/8120

ci-tester-lunarg commented 3 weeks ago

CI Vulkan-ValidationLayers build queued with queue ID 200449.

ci-tester-lunarg commented 3 weeks ago

CI Vulkan-ValidationLayers build # 16826 running.

ci-tester-lunarg commented 3 weeks ago

CI Vulkan-ValidationLayers build # 16826 failed.

ci-tester-lunarg commented 3 weeks ago

CI Vulkan-ValidationLayers build queued with queue ID 200879.

ci-tester-lunarg commented 3 weeks ago

CI Vulkan-ValidationLayers build # 16831 running.

ci-tester-lunarg commented 3 weeks ago

CI Vulkan-ValidationLayers build # 16831 failed.

ci-tester-lunarg commented 3 weeks ago

CI Vulkan-ValidationLayers build queued with queue ID 200900.

ci-tester-lunarg commented 3 weeks ago

CI Vulkan-ValidationLayers build # 16832 running.

ci-tester-lunarg commented 3 weeks ago

CI Vulkan-ValidationLayers build # 16832 failed.

ci-tester-lunarg commented 3 weeks ago

CI Vulkan-ValidationLayers build queued with queue ID 200966.

ci-tester-lunarg commented 3 weeks ago

CI Vulkan-ValidationLayers build # 16833 running.

ci-tester-lunarg commented 3 weeks ago

CI Vulkan-ValidationLayers build # 16833 passed.

ci-tester-lunarg commented 3 weeks ago

CI Vulkan-ValidationLayers build queued with queue ID 201971.

ci-tester-lunarg commented 3 weeks ago

CI Vulkan-ValidationLayers build # 16842 running.

ci-tester-lunarg commented 3 weeks ago

CI Vulkan-ValidationLayers build # 16842 passed.

ci-tester-lunarg commented 3 weeks ago

CI Vulkan-ValidationLayers build queued with queue ID 202208.

ci-tester-lunarg commented 3 weeks ago

CI Vulkan-ValidationLayers build # 16843 running.

ci-tester-lunarg commented 3 weeks ago

CI Vulkan-ValidationLayers build # 16843 passed.

ci-tester-lunarg commented 2 weeks ago

CI Vulkan-ValidationLayers build queued with queue ID 202399.

ci-tester-lunarg commented 2 weeks ago

CI Vulkan-ValidationLayers build # 16847 running.

ci-tester-lunarg commented 2 weeks ago

CI Vulkan-ValidationLayers build # 16847 passed.