search

KhronosGroup / Vulkan-ValidationLayers

Vulkan Validation Layers (VVL)
https://vulkan.lunarg.com/doc/sdk/latest/linux/khronos_validation_layer.html
Other
751 stars 403 forks source link

layers: Remove old Sync Val enable enum #8158

Closed spencer-lunarg closed 3 months ago

spencer-lunarg commented 3 months ago

@jzulauf-lunarg @mark-lunarg so I just came across https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/1976 and there is both a VK_VALIDATION_FEATURE_ENABLE_SYNCHRONIZATION_VALIDATION and VK_VALIDATION_FEATURE_ENABLE_SYNCHRONIZATION_VALIDATION_EXT that was added.

But the logic for SetValidationFeatureEnable2 make no sense because VK_VALIDATION_FEATURE_ENABLE_SYNCHRONIZATION_VALIDATION is 0 but it will hit VK_VALIDATION_FEATURE_ENABLE_GPU_ASSISTED_EXT first (that is also 0)

... basically I think I should be able to remove SetValidationFeatureEnable2and the original VK_VALIDATION_FEATURE_ENABLE_SYNCHRONIZATION_VALIDATION

ci-tester-lunarg commented 3 months ago

CI Vulkan-ValidationLayers build queued with queue ID 202325.

ci-tester-lunarg commented 3 months ago

CI Vulkan-ValidationLayers build # 16846 running.

ci-tester-lunarg commented 3 months ago

CI Vulkan-ValidationLayers build # 16846 passed.