KhronosGroup / Vulkan-ValidationLayers

Vulkan Validation Layers (VVL)
https://vulkan.lunarg.com/doc/sdk/latest/linux/khronos_validation_layer.html
Other
727 stars 396 forks source link

layers: Remove unused unistd.h includes #8175

Closed pinotree closed 2 weeks ago

pinotree commented 2 weeks ago

The sources seem to build fine even without them (at least on Linux), so drop these OS-specific includes.

ci-tester-lunarg commented 2 weeks ago

Author pinotree not on autobuild list. Waiting for curator authorization before starting CI build.

CLAassistant commented 2 weeks ago

CLA assistant check
All committers have signed the CLA.

ci-tester-lunarg commented 2 weeks ago

Author pinotree not on autobuild list. Waiting for curator authorization before starting CI build.

pinotree commented 2 weeks ago

I'm curious how you noticed this

Because of my GNU/Hurd porting (#8177): rather than adding more ifdefs, I decided to drop the ones that were not needed (at least as it seemed).

ci-tester-lunarg commented 2 weeks ago

CI Vulkan-ValidationLayers build queued with queue ID 204275.

ci-tester-lunarg commented 2 weeks ago

CI Vulkan-ValidationLayers build # 16879 running.

ci-tester-lunarg commented 2 weeks ago

CI Vulkan-ValidationLayers build # 16879 failed.

spencer-lunarg commented 2 weeks ago

CI Vulkan-ValidationLayers build # 16879 failed.

The error logs are showing strange github/internet issue

ssh: Could not resolve hostname github.com: Temporary failure in name resolution

will wait a bit and kick it off again and get this in soon

ci-tester-lunarg commented 2 weeks ago

CI Vulkan-ValidationLayers build queued with queue ID 204335.

ci-tester-lunarg commented 2 weeks ago

CI Vulkan-ValidationLayers build # 16882 running.

ci-tester-lunarg commented 2 weeks ago

CI Vulkan-ValidationLayers build # 16882 failed.

ci-tester-lunarg commented 2 weeks ago

CI Vulkan-ValidationLayers build queued with queue ID 204404.

ci-tester-lunarg commented 2 weeks ago

CI Vulkan-ValidationLayers build # 16886 running.

ci-tester-lunarg commented 2 weeks ago

CI Vulkan-ValidationLayers build # 16886 passed.