search

KhronosGroup / Vulkan-ValidationLayers

Vulkan Validation Layers (VVL)
https://vulkan.lunarg.com/doc/sdk/latest/linux/khronos_validation_layer.html
Other
751 stars 402 forks source link

build: Automate self vvl renaming #8185

Closed spencer-lunarg closed 3 months ago

spencer-lunarg commented 3 months ago

This will -DBUILD_SELF_VVL=ON in CI to be able to build the Self Validation so we can run on it easier

cc @arno-lunarg

ci-tester-lunarg commented 3 months ago

CI Vulkan-ValidationLayers build queued with queue ID 205710.

ci-tester-lunarg commented 3 months ago

CI Vulkan-ValidationLayers build # 16901 passed.

y-novikov commented 3 months ago

ANGLE isn't able to load VK_LAYER_KHRONOS_validation after this: https://chromium-review.googlesource.com/c/angle/angle/+/5650353

Could you please update BUILD.gn similarly to CMakeLists.txt? @cnorthrop

y-novikov commented 3 months ago

@dneto0 in case you wonder why https://chromium-review.googlesource.com/c/chromium/src/+/5650456 failed.

spencer-lunarg commented 3 months ago

Created https://github.com/KhronosGroup/Vulkan-ValidationLayers/pull/8188

I only grepped in BUILD.gn but seems there is some extra script (wasn't aware of) that is where these JSON files are injected with the string