Closed spencer-lunarg closed 3 months ago
CI Vulkan-ValidationLayers build queued with queue ID 208236.
CI Vulkan-ValidationLayers build # 16957 running.
CI Vulkan-ValidationLayers build # 16957 passed.
CI Vulkan-ValidationLayers build queued with queue ID 208373.
CI Vulkan-ValidationLayers build # 16958 running.
CI Vulkan-ValidationLayers build # 16958 passed.
closes https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/8202
The main goal was to try and make it clear in the pipeline validation where/when we have a renderpass/dynamic rendering/GPL being used
The core issue was we were mixing up
rp_state == NULL
when using something like GPL Vertex Input and there is no state OR there is a bad handle to VkRenderPasspipeline.GraphicsCreateInfo().renderPass == VK_NULL_HANDLE
when the passed in value is null (which can be from Dynamic Rendering OR GPL)rp_state && rp_state.UsesDynamicRendering()
which is when the pipeline passes in null, but we created avvl::RenderPass
atvkCmdBeginRendering
and so there is a state objectCore issue is that
vvl::RenderPass
is used for dynamic rendering where there might not be an actualVkRenderPass VkHandle()
under it