Incorrect message/handling of VUID-vkCmdBeginQuery-None-00807

[jeroenbakker-atmind]

Environment:

• OS: Linux-6.5.0-41-generic-x86_64-with-glibc2.35 64 Bits, X11 UI

• GPU and driver version: AMD W7800 PRO (RADV GFX1100) Advanced Micro Devices 23.2.1

• SDK or header version if building from repo: 1.3.283.0

• Options enabled (synchronization, best practices, etc.):

Describe the Issue

When using vkCmdBeginQuery on a just created pool (VK_QUERY_TYPE_OCCLUSION) without VK_EXT_host_query_reset/hostQueryReset=false. the VUID-vkCmdBeginQuery-None-00807 is raised. In the vulkan specification the description of this error is All queries used by the command must be unavailable. However the actual message currently shown is

VUID-vkCmdBeginQuery-None-00807(ERROR / SPEC): msgNum: 680962600 - Validation Error: [ VUID-vkCmdBeginQuery-None-00807 ] Object 0: handle = 0x7fff5bc4ec40, type = VK_OBJECT_TYPE_COMMAND_BUFFER; Object 1: handle = 0xc6745600000013fb, type = VK_OBJECT_TYPE_QUERY_POOL; | MessageID = 0x2896aa28 | vkCmdBeginQuery(): VkQueryPool 0xc6745600000013fb[] and query 0: query not reset. After query pool creation, each query must be reset before it is used. Queries must also be reset between uses. The Vulkan spec states: All queries used by the command must be unavailable (https://vulkan.lunarg.com/doc/view/1.3.283.0/linux/1.3-extensions/vkspec.html#VUID-vkCmdBeginQuery-None-00807).

Resetting the state of the queries seems onlyu possible by enabling the VK_EXT_host_query_reset extension/feature and calling vkResetQueryPool. Which seems like a bit strange as it makes occlusion queries unusable without this extension/feature.

Expected behavior

I am not sure if this is a false positive, or that the documentation is unclear what the minimum setup of using occlusion queries is. But I expected that all values where unavailable.

Additional context

• -Download blender from https://builder.blender.org/download/patch/PR123878/ It contains main blender with an initial implementation of occlusion queries https://projects.blender.org/blender/blender/pulls/123878 the core implementation is at https://projects.blender.org/blender/blender/pulls/123878/files#diff-5df3240251d50b6716a65414a2d55195c8df15ab
• Use vkconfig to enable validation layers.
• Start blender with blender --debug-gpu --gpu-backend vulkan
• Click inside the 3d viewport.

[spencer-lunarg]

@jeroenbakker-atmind the idea is you need to go

vkCmdResetQueryPool();
vkCmdBeginQuery()

Resetting the state of the queries seems onlyu possible by enabling the VK_EXT_host_query_reset extension/feature and calling vkResetQueryPool

so there is a vkCmdResetQueryPool ... I guess a simple improvement would to say that more clearly in the error message

[jeroenbakker-atmind]

Ah will check on Monday. Might be that I misread the specs. 'each query' might point into a certain direction in the message.

[jeroenbakker-atmind]

I retested and of course there was an error on our side. Thanks for pointing it out! The validation is correct, the message can be improved a bit to point the developer into the right direction as you already stated.

[spencer-lunarg]

I have said it and will say again - A bad validation error message IS a bug ... please feel free to open issues or ping me anytime