search

KhronosGroup / Vulkan-ValidationLayers

Vulkan Validation Layers (VVL)
https://vulkan.lunarg.com/doc/sdk/latest/linux/khronos_validation_layer.html
Other
748 stars 400 forks source link

sync: Fix HandleRecord increased memory usage #8237

Closed artem-lunarg closed 2 months ago

artem-lunarg commented 2 months ago

I forgot to clean up handles in CommandBufferAccessContext::Reset. With this fix the memory consumption by HandleRecord objects in doom capture is ~7MB (previously ~700MB).

There is an opportunity to de-duplicate groups of handles which might reduce HandleRecord memory usage to < 1MB range for complex workloads. That's a backup plan if we need to get rid of few more MBs.

Also improvements to syncval stats system.

ci-tester-lunarg commented 2 months ago

CI Vulkan-ValidationLayers build queued with queue ID 211763.

ci-tester-lunarg commented 2 months ago

CI Vulkan-ValidationLayers build # 16993 running.

ci-tester-lunarg commented 2 months ago

CI Vulkan-ValidationLayers build # 16993 passed.