layers: Reorganize renderpass framebuffer checks

KhronosGroup / Vulkan-ValidationLayers

Vulkan Validation Layers (VVL)

https://vulkan.lunarg.com/doc/sdk/latest/linux/khronos_validation_layer.html

Other

748 stars 400 forks source link

layers: Reorganize renderpass framebuffer checks #8245

Closed spencer-lunarg closed 2 months ago

spencer-lunarg commented 2 months ago

The Renderpass/Framebuffer creations checks were getting long and a tad out-of-hand

This does 3 things

Moves more checks to stateless where possible
Groups logical extension logic to own function
Pass by reference as much as possible (instead of pointers)

ci-tester-lunarg commented 2 months ago

CI Vulkan-ValidationLayers build queued with queue ID 212917.

ci-tester-lunarg commented 2 months ago

CI Vulkan-ValidationLayers build queued with queue ID 212928.

ci-tester-lunarg commented 2 months ago

CI Vulkan-ValidationLayers build # 17008 running.

ci-tester-lunarg commented 2 months ago

CI Vulkan-ValidationLayers build # 17008 passed.

spencer-lunarg commented 2 months ago

@r-potter heads up - if you had a change in the work, might have to rebase around this... don't plan to touch this code much anymore and if you also find things worth cleaning up around the framebuffer / renderpass logic, please don't hesitate