search

KhronosGroup / Vulkan-ValidationLayers

Vulkan Validation Layers (VVL)
https://vulkan.lunarg.com/doc/sdk/latest/linux/khronos_validation_layer.html
Other
748 stars 400 forks source link

Android GN fixes + CI job #8254

Closed mikes-lunarg closed 2 months ago

mikes-lunarg commented 2 months ago

Follow-on fix for Android-specific GN issue in #8242 and a new Android CI job to try and catch these in the future.

ci-tester-lunarg commented 2 months ago

CI Vulkan-ValidationLayers build queued with queue ID 214245.

ci-tester-lunarg commented 2 months ago

CI Vulkan-ValidationLayers build # 17024 running.

mikes-lunarg commented 2 months ago

I did push the first 2 commits by themselves to make sure it repros the error

Run python scripts/gn/gn.py --args='target_os="android" target_cpu="arm64"'
Cloning into 'depot_tools'...
Starting builds in /home/runner/work/Vulkan-ValidationLayers/Vulkan-ValidationLayers/external
WARNING: Your metrics.cfg file was invalid or nonexistent. A new one will be created.
________ running 'python3 build/linux/sysroot_scripts/install-sysroot.py --arch=x[6](https://github.com/mikes-lunarg/Vulkan-ValidationLayers/actions/runs/9852828179/job/27202107985#step:4:7)4' in '/home/runner/work/Vulkan-ValidationLayers/Vulkan-ValidationLayers/.'
Installing Debian bullseye amd64 root image: /home/runner/work/Vulkan-ValidationLayers/Vulkan-ValidationLayers/build/linux/debian_bullseye_amd64-sysroot
Downloading https://commondatastorage.googleapis.com/chrome-linux-sysroot/dec[7](https://github.com/mikes-lunarg/Vulkan-ValidationLayers/actions/runs/9852828179/job/27202107985#step:4:8)a3a0fc5b83b909cba1b6d119077e0429a138eadef6bf5a0f2e03b1904631
Hook 'python3 build/linux/sysroot_scripts/install-sysroot.py --arch=x64' took 10.53 secs
________ running 'python3 tools/clang/scripts/update.py' in '/home/runner/work/Vulkan-ValidationLayers/Vulkan-ValidationLayers/.'
Downloading https://commondatastorage.googleapis.com/chromium-browser-clang/Linux_x64/clang-llvmorg-19-init-14561-gecea[8](https://github.com/mikes-lunarg/Vulkan-ValidationLayers/actions/runs/9852828179/job/27202107985#step:4:9)371-2.tar.xz .......... Done.
ERROR at //BUILD.gn:23:19: Assignment had no effect.
vulkan_data_dir = "$root_out_dir/$vulkan_data_subdir"
                  ^----------------------------------
You set the variable "vulkan_data_dir" here and it was unused before it went
out of scope.
Command "gn gen --check out --args=target_os="android" target_cpu="arm64"" failed with return code 1
Error: Process completed with exit code 1.
ci-tester-lunarg commented 2 months ago

CI Vulkan-ValidationLayers build # 17024 passed.