KhronosGroup / Vulkan-ValidationLayers

Vulkan Validation Layers (VVL)
https://vulkan.lunarg.com/doc/sdk/latest/linux/khronos_validation_layer.html
Other
748 stars 400 forks source link

sync: Make shader_access_heuristic disabled by default #8279

Closed artem-lunarg closed 2 months ago

artem-lunarg commented 2 months ago

Improvements to SPIR-V static analysis allowed to properly identify some accesses as writes (previously there were erroneously classified as reads). This increased the number of cases where current validation of shader accesses results in false-positive reports. This makes current heuristic less suitable to be enabled by default.

Some additional improvements to the heuristic are planned. It can be useful in some scenarios, but fundamentally it can't be a false-positive free solution.

ci-tester-lunarg commented 2 months ago

CI Vulkan-ValidationLayers build queued with queue ID 217023.

ci-tester-lunarg commented 2 months ago

CI Vulkan-ValidationLayers build # 17060 running.

ci-tester-lunarg commented 2 months ago

CI Vulkan-ValidationLayers build queued with queue ID 217035.

ci-tester-lunarg commented 2 months ago

CI Vulkan-ValidationLayers build # 17061 running.

ci-tester-lunarg commented 2 months ago

CI Vulkan-ValidationLayers build # 17061 passed.

ci-tester-lunarg commented 2 months ago

CI Vulkan-ValidationLayers build queued with queue ID 217130.

ci-tester-lunarg commented 2 months ago

CI Vulkan-ValidationLayers build # 17064 running.

ci-tester-lunarg commented 2 months ago

CI Vulkan-ValidationLayers build # 17064 passed.

ci-tester-lunarg commented 2 months ago

CI Vulkan-ValidationLayers build queued with queue ID 217174.

ci-tester-lunarg commented 2 months ago

CI Vulkan-ValidationLayers build # 17066 running.

ci-tester-lunarg commented 2 months ago

CI Vulkan-ValidationLayers build # 17066 passed.